Improve docker build#294
Open
orgads wants to merge 1 commit into
Open
Conversation
orgads
commented
Jun 24, 2023
orgads
commented
Contributor
- Use current code instead of cloning from github.
- Use multi-stage instead of deleting everything.
orgads
force-pushed
the
improve-docker
branch
2 times, most recently
from
b103eea to
4083778
Compare
Collaborator
|
Hmm this fails for me. Also, I don't like the fact that now we have lost the ability to see the specific git tag that this was built from. |
Contributor
Author
|
The failure is: I don't see how that's related to any of my changes. |
orgads
force-pushed
the
improve-docker
branch
2 times, most recently
from
88393b1 to
fc0ad4b
Compare
Contributor
Author
|
How about now? You can build with |
Contributor
Author
|
Rebased. @davehorton ping. |
orgads
force-pushed
the
improve-docker
branch
from
1429f03 to
ac584d8
Compare
orgads
force-pushed
the
improve-docker
branch
from
ac584d8 to
0fb3571
Compare
Contributor
Author
|
ping |
orgads
force-pushed
the
improve-docker
branch
from
0fb3571 to
45e3179
Compare
* Use current code instead of cloning from github. * Use multi-stage instead of deleting everything.
orgads
force-pushed
the
improve-docker
branch
from
45e3179 to
d6aef20
Compare
Contributor
Author
|
Rebased |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.